nikrozman/element-web
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Remove redundant code

Browse Source 
On a timeline action, we return early if payload.room is falsy.
So then why do we need to retry fetching the room?
I think this can be removed but will ask others if there's some
conext I'm missing.
This commit is contained in:
R Midhun Suresh
2025-03-02 18:16:43 +05:30
parent 9f0f7826a0
commit 9fae0012c8
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/stores/room-list-v3/RoomListStoreV3.ts
View File

@@ -138,18 +138,9 @@ export class RoomListStoreV3Class extends AsyncStoreWithClient<EmptyObject> {
if (!payload.isLiveEvent || !payload.isLiveUnfilteredRoomTimelineEvent || !payload.room) return;
const roomId = payload.event.getRoomId();
const findAndAddRoom = (): boolean => {
const room = this.matrixClient?.getRoom(roomId);
if (room) this.addRoomAndEmit(room);
return !!room;
};
// We'll try finding the room associated with this event.
// If we can't find the room, we'll try again after 100ms.
if (!findAndAddRoom()) {
logger.warn(`Live timeline event ${payload.event.getId()} received without associated room`);
logger.warn(`Queuing failed room update for retry as a result.`);
setTimeout(findAndAddRoom, 100);
}
const room = this.matrixClient?.getRoom(roomId);
if (room) this.addRoomAndEmit(room);
else logger.warn(`Live timeline event ${payload.event.getId()} received without associated room`);
break;
}
@@ -165,7 +156,6 @@ export class RoomListStoreV3Class extends AsyncStoreWithClient<EmptyObject> {
const prevRoom = this.matrixClient?.getRoom(predecessor.roomId);
if (prevRoom) this.roomSkipList.removeRoom(prevRoom);
else logger.warn(`Unable to find predecessor room with id ${predecessor.roomId}`);
}
}
this.addRoomAndEmit(payload.room);