Merge pull request #1565 from matrix-org/matthew/group-promise-npe

turn NPE on flair resolution errors into a logged error
2017-11-01 22:18:05 +00:00
parent acd1f31010 7d7cd30e46
commit 815b42f0ac
1 changed files with 5 additions and 1 deletions
--- a/src/stores/FlairStore.js
+++ b/src/stores/FlairStore.js
@@ -129,7 +129,11 @@ class FlairStore extends EventEmitter {
        }
        const updatedUserGroups = resp.users;
        usersInFlight.forEach((userId) => {
-            this._usersPending[userId].resolve(updatedUserGroups[userId] || []);
+            if (this._usersPending[userId]) {
+                this._usersPending[userId].resolve(updatedUserGroups[userId] || []);
+            } else {
+                console.error("Promise vanished for resolving groups for " + userId);
+            }
        });
    }