nikrozman/element-web
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Live location sharing: fix code smells - return useEffect unsub, dont map (#8535)

Browse Source 
Signed-off-by: Kerry Archibald <kerrya@element.io>
This commit is contained in:
Kerry
2022-05-09 10:42:05 +02:00
committed by GitHub
parent aa8e3dbfb4
commit 7e15bef062
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/views/beacon/LeftPanelLiveShareWarning.tsx
View File

@@ -68,13 +68,13 @@ const useLivenessMonitor = (liveBeaconIds: BeaconIdentifier[], beacons: Map<Beac
// refresh beacon monitors when the tab becomes active again
const onPageVisibilityChanged = () => {
if (document.visibilityState === 'visible') {
liveBeaconIds.map(identifier => beacons.get(identifier)?.monitorLiveness());
liveBeaconIds.forEach(identifier => beacons.get(identifier)?.monitorLiveness());
}
};
if (liveBeaconIds.length) {
document.addEventListener("visibilitychange", onPageVisibilityChanged);
}
() => {
return () => {
document.removeEventListener("visibilitychange", onPageVisibilityChanged);
};
}, [liveBeaconIds, beacons]);