Return RLS instance through function to avoid import side effect (#31091)

* Attach function that returns instance

So that just importing this file does not create a RLS instance.

* Fix jest test

src/@types/global.d.ts

@@ -98,7 +98,7 @@ declare global {
         mxToastStore: ToastStore;
         mxDeviceListener: DeviceListener;
         mxRoomListStore: RoomListStore;
-        mxRoomListStoreV3: RoomListStoreV3Class;
+        getRoomListStoreV3: () => RoomListStoreV3Class;
         mxRoomListLayoutStore: RoomListLayoutStore;
         mxPlatformPeg: PlatformPeg;
         mxIntegrationManagers: typeof IntegrationManagers;

src/stores/room-list-v3/RoomListStoreV3.ts

@@ -373,4 +373,4 @@ export default class RoomListStoreV3 {
     }
 }
 
-window.mxRoomListStoreV3 = RoomListStoreV3.instance;
+window.getRoomListStoreV3 = () => RoomListStoreV3.instance;

test/unit-tests/components/viewmodels/roomlist/RoomListHeaderViewModel-test.tsx

@@ -48,6 +48,9 @@ describe("useRoomListHeaderViewModel", () => {
     beforeEach(() => {
         matrixClient = stubClient();
         space = mkStubRoom("spaceId", "spaceName", matrixClient);
+        jest.spyOn(SettingsStore, "getValue").mockImplementation((name: string): any => {
+            if (name === "RoomList.preferredSorting") return SortingAlgorithm.Recency;
+        });
     });
 
     afterEach(() => {