2698ad422e
* Move shared components to a packages/ directory so they can be publish more sensibly * Iterate towards split out shared-components module * Move shared component source into src/ subdir * Fix up imports * Include shared components in babel-ing (again) * Remove now unused dependencies * Update import in storybook preview * ...except of course they aren't unused if we import the shared components by source * Ignore shared components deps * Add shared-components to i18n paths and upgrade web-i18n to version that supports doing so * Move storybook stuff to shared-components * Seems we don't need this anymore... * Remove unused deps and remove storybook plugin from eslint * Presumably working-directory is only valid on run steps * Ignore dep & run prettier * Prettier on knips.ts * Hopefully run in right dir * Remember how to software write * Okay... how about THIS way? * Oh right, they were git ignored. Sigh. * Add concurrently * Ignore in knip * Better? * Paaaaaaaackageeeeeeees * More packages * Move playwright snapshots * Still need a custom snapshots dir * Add eslint back * Oh, now knip sees them * Fix another import * Don't lint shared-components with everything else Okay, eslint & tsconfig are tied too closely for this to work and running tsc on the shared components will need its deps installing * Maybe lint shared components please? * Not quite * Remove storybook again Re-check if it does work without it * Remove storybook eslint plugin as we're not linting storybook here anymore * Remove this too * We do need it here though
148 lines
4.5 KiB
YAML
148 lines
4.5 KiB
YAML
name: Static Analysis
|
|
on:
|
|
pull_request: {}
|
|
push:
|
|
branches: [develop, master]
|
|
merge_group:
|
|
types: [checks_requested]
|
|
repository_dispatch:
|
|
types: [element-web-notify]
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
# This must be set for fetchdep.sh to get the right branch
|
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
|
|
|
permissions: {} # No permissions required
|
|
|
|
jobs:
|
|
ts_lint:
|
|
name: "Typescript Syntax Check"
|
|
runs-on: ubuntu-24.04
|
|
steps:
|
|
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
|
|
|
|
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
|
|
with:
|
|
cache: "yarn"
|
|
node-version: "lts/*"
|
|
|
|
- name: Install Dependencies
|
|
run: "./scripts/layered.sh"
|
|
|
|
- name: Typecheck
|
|
run: "yarn run lint:types"
|
|
|
|
- name: Install Shared Component Dependencies
|
|
run: "yarn --cwd packages/shared-components install"
|
|
|
|
- name: Typecheck Shared Components
|
|
run: "yarn --cwd packages/shared-components run lint:types"
|
|
|
|
i18n_lint:
|
|
name: "i18n Check"
|
|
uses: matrix-org/matrix-web-i18n/.github/workflows/i18n_check.yml@main
|
|
permissions:
|
|
pull-requests: read
|
|
with:
|
|
hardcoded-words: "Element"
|
|
allowed-hardcoded-keys: |
|
|
console_dev_note
|
|
labs|element_call_video_rooms
|
|
labs|feature_disable_call_per_sender_encryption
|
|
voip|element_call
|
|
error|invalid_json
|
|
error|misconfigured
|
|
welcome_to_element
|
|
devtools|settings|elementCallUrl
|
|
labs|sliding_sync_description
|
|
|
|
rethemendex_lint:
|
|
name: "Rethemendex Check"
|
|
runs-on: ubuntu-24.04
|
|
steps:
|
|
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
|
|
|
|
- run: ./res/css/rethemendex.sh
|
|
|
|
- run: git diff --exit-code
|
|
|
|
js_lint:
|
|
name: "ESLint"
|
|
runs-on: ubuntu-24.04
|
|
steps:
|
|
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
|
|
|
|
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
|
|
with:
|
|
cache: "yarn"
|
|
node-version: "lts/*"
|
|
|
|
# Does not need branch matching as only analyses this layer
|
|
- name: Install Deps
|
|
run: "yarn install --frozen-lockfile"
|
|
|
|
- name: Run Linter
|
|
run: "yarn run lint:js"
|
|
|
|
- name: Install Shared Component Deps
|
|
run: "yarn --cwd packages/shared-components install --frozen-lockfile"
|
|
|
|
- name: Run Linter
|
|
run: "yarn --cwd packages/shared-components run lint:js"
|
|
|
|
style_lint:
|
|
name: "Style Lint"
|
|
runs-on: ubuntu-24.04
|
|
steps:
|
|
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
|
|
|
|
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
|
|
with:
|
|
cache: "yarn"
|
|
node-version: "lts/*"
|
|
|
|
# Does not need branch matching as only analyses this layer
|
|
- name: Install Deps
|
|
run: "yarn install"
|
|
|
|
- name: Run Linter
|
|
run: "yarn run lint:style"
|
|
|
|
workflow_lint:
|
|
name: "Workflow Lint"
|
|
runs-on: ubuntu-24.04
|
|
steps:
|
|
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
|
|
|
|
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
|
|
with:
|
|
cache: "yarn"
|
|
node-version: "lts/*"
|
|
|
|
# Does not need branch matching as only analyses this layer
|
|
- name: Install Deps
|
|
run: "yarn install --frozen-lockfile"
|
|
|
|
- name: Run Linter
|
|
run: "yarn lint:workflows"
|
|
|
|
analyse_dead_code:
|
|
name: "Analyse Dead Code"
|
|
runs-on: ubuntu-24.04
|
|
steps:
|
|
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
|
|
|
|
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
|
|
with:
|
|
cache: "yarn"
|
|
node-version: "lts/*"
|
|
|
|
- name: Install Deps
|
|
run: "yarn install --frozen-lockfile"
|
|
|
|
- name: Run linter
|
|
run: "yarn run lint:knip"
|