nikrozman/element-web
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity
46,107 Commits 258 Branches 582 Tags
8abe3922944d3cd0284de1fb35f072d1b7b84d2d
Commit Graph

2542 Commits

Author SHA1 Message Date
Michael Telatynski
f52fab39fc Use aria descriptions instead of labels for TextWithTooltip (#10952) 
* Use aria descriptions instead of labels for TextWithTooltip

to prevent clobbering the reading of the content

* Update snapshot

* Fix snapshots

* Iterate

* Update snapshots

* delint
 2023-05-25 08:42:09 +00:00
Oliver Sand
a0c2676c38 Pass device id to widgets (#10209) 
* Pass device id to widget

Implement the [comment in MSC 3819](https://github.com/matrix-org/matrix-spec-proposals/pull/3819#discussion_r1099833846) which requests passing a device id to a widget.

This is based on the previous work in the matrix-widget-api: https://github.com/matrix-org/matrix-widget-api/pull/78

Signed-off-by: Oliver Sand <oliver.sand@nordeck.net>

* Include all data that is shared in the permissions screen

* Update matrix-widget-api to version 1.4.0

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>

* Fix type and test

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>

---------

Signed-off-by: Oliver Sand <oliver.sand@nordeck.net>
Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Co-authored-by: Dominik Henneke <dominik.henneke@nordeck.net>
 2023-05-23 13:35:31 +00:00
Suguru Hirahara
b7cd1f00fc Use Icon component for icons on AppTile's menu bar (#10955) 
* Use icon component for buttons on mx_AppTileMenuBar_widgets

* Remove redundant declarations

* Add a Percy snapshot test

* Set color value to mx_Icon, fill and stroke with currentColor

* Iterate
 2023-05-22 07:48:40 +00:00
Suguru Hirahara
e652177706 Use classNames function for appTileBodyClass on AppTile.tsx (#10939) 2023-05-19 15:18:18 +00:00
Michael Telatynski
2da199c41d Remove url npm dependency and use Web URL constructor (#10930) 2023-05-17 12:50:00 +01:00
Suguru Hirahara
7917d973e7 Fix widget permission tooltip style rules by applying the naming policy properly (#10916) 2023-05-17 08:51:18 +00:00
Michael Telatynski
6a3f59cc76 Make more of the codebase conform to strict types (#10857) 2023-05-16 14:25:43 +01:00
Suguru Hirahara
2eedfbf566 Split mx_AppPermissionWarning on _AppsDrawer.pcss into two classes (#10824) 
* Separate mx_AppWarning and mx_AppPermission

* Remove mx_AppPermission_row for a type selector

* Nest: mx_AppPermission

* Run prettier

* Create a CSS file for AppPermission
 2023-05-16 11:14:52 +01:00
Suguru Hirahara
5988bb9a68 Fix ResizeHandle of the third pinned widget (#10896) 
* Revert "Remove unused prop from ResizeHandle - reverse (#10771)"

This reverts commit 62569e209e.

* Add a comment
 2023-05-15 07:40:15 +00:00
Michael Telatynski
f758cbd38a Make more of the codebase conform to strict types (#10859) 2023-05-12 09:49:37 +01:00
Michael Telatynski
82e32035fd Conform more of the codebase to strictNullChecks (#10842) 2023-05-11 09:56:56 +01:00
Michael Telatynski
456c66db5b Conform more of the codebase to strictNullChecks (#10800) 2023-05-10 08:41:55 +01:00
Suguru Hirahara
5cdbdd9f97 Update some class names of AppTile on the naming policy (#10777) 2023-05-09 21:07:12 +00:00
Suguru Hirahara
a0228994dc Remove unused class names from AppWarning (#10823) 2023-05-09 07:59:42 +00:00
Suguru Hirahara
aed5fcf64a Update mx_AppLoading to improve maintainability (#10783) 
* Nesting: mx_AppLoading

* Conform class and animation name to the naming policy

* Nesting for maintainability, preventing the rule from becoming an orphan

* Rename the class: mx_AppLoading to mx_AppTile_loading
 2023-05-08 12:38:04 +00:00
Suguru Hirahara
53fcb0c36e Remove mixin mx_Tooltip_dark and rename class mx_Tooltip_dark (#10801) 
* Remove a mixin - mx_Tooltip_dark

The mixin has been used on `_AppsDrawer.pcss` only.

* Rename mx_Tooltip_dark based on the naming policy

'mx_Tooltip_dark' has been used on `AppPermission.tsx` only.
 2023-05-08 03:01:00 +00:00
Michael Telatynski
99ac9e5029 Ensure tooltip contents is linked via aria to the target element (#10729) 
* Ensure tooltip contents is linked via aria to the target element

* Iterate

* Fix tests

* Fix tests

* Update snapshot

* Fix missing aria labels for more tooltips

* Iterate

* Update snapshots
 2023-05-05 08:26:11 +00:00
Kerry
1f4d857283 Apply strictNullChecks to src/components/views/settings (#10724) 2023-05-05 09:13:50 +01:00
Suguru Hirahara
3ca957b541 Update _ResizeHandle.pcss (#10772) 
* Nesting: `mx_ResizeHandle`

* Nesting: `> div`

* Run prettier

* Use a custom property

* Remove a redundant declaration: `cursor: row-resize`

The resizer is either vertical or horizontal, and since `cursor: row-resize` is applied by default, it does not need to be repeated here.

* Conform the class names to the naming policy

* Revert "Use a custom property"

This reverts commit 6116939eec7d9e4220b89a638623e5876e143adf.
 2023-05-04 15:19:55 +00:00
Suguru Hirahara
af3a0e3d59 Update some class names of AppTile (AppTileMenuBar_iconButton) on the naming policy (#10778) 2023-05-03 12:42:36 +00:00
Suguru Hirahara
62569e209e Remove unused prop from ResizeHandle - reverse (#10771) 
It was added by 928b6d47c8 and soon deprecated by e5d1b3328c
 2023-05-03 12:25:33 +00:00
Michael Telatynski
f5d05f3284 Memoize field validation results (#10714) 
* Memoize field validation results

* Make validation memoization opt-in
 2023-04-27 11:34:02 +00:00
Michael Telatynski
a629ce3a53 Use generics to better type TabbedView (#10726) 2023-04-27 12:55:29 +01:00
Michael Telatynski
619a9e8542 Conform more of the codebase with strictNullChecks (#10703) 2023-04-25 09:28:48 +01:00
Michael Telatynski
792a39a39b ARIA Accessibility improvements (#10675) 
* Fix confusing tab indexes in EventTilePreview

* Stop using headings inside buttons

* Prefer labelledby and describedby over duplicated aria-labels

* Improve semantics of tables used in settings

* Fix types

* Update tests

* Fix timestamps
 2023-04-21 09:48:48 +00:00
Michael Telatynski
782060a26e ARIA Accessibility improvements (#10674) 
* Add missing aria-expanded attributes

* Improve autoComplete for phone numbers & email addresses

* Fix room summary card heading order

* Fix missing label on timeline search field

* Use appropriate semantic elements for dropdown listbox

* Use semantic list elements in keyboard settings tab

* Use semantic list elements in spotlight

* Fix types and i18n

* Improve types

* Update tests

* Add snapshot test
 2023-04-20 17:13:30 +00:00
Michael Telatynski
2da52372d4 Add arrow key controls to emoji and reaction pickers (#10637) 
* Add arrow key controls to emoji and reaction pickers

* Iterate types

* Switch to using aria-activedescendant

* Add tests

* Fix tests

* Iterate

* Update test

* Tweak header keyboard navigation behaviour

* Also handle scrolling on left/right arrow keys

* Iterate
 2023-04-20 14:56:21 +00:00
Michael Telatynski
1efa82917a Fix wrong room topic tooltip position (#10667) 
* Fix wrong room topic tooltip position

* Update snapshots

* Fix tests
 2023-04-20 08:25:53 +00:00
Michael Telatynski
1a0e5c1805 Fix multiple accessibility defects identified by AXE (#10606) 
* Mark effects overlay canvas as aria hidden

* Ensure date separators aren't seen as focusable aria separators

* Fix

* Fix font slider not having aria label

* Add missing aria labels

* Fix settings flags setting aria-checked={null}

* Update snapshots
 2023-04-17 16:09:45 +00:00
kenwuuu
dc4bb237d4 Replace hardcoded strings with MsgType constants (#10604) 
* replace hardcoded strings with MsgType constants

* fix import and revert comments

Signed-off-by: Ken Wu kenqiwu@gmail.com

* fix import

Signed-off-by: Ken Wu kenqiwu@gmail.com

---------

Signed-off-by: Ken Wu kenqiwu@gmail.com
 2023-04-17 09:37:29 +00:00
Michael Telatynski
56e4ae41f8 Conform more of the codebase to strictNullChecks (#10607) 
* Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`

* Fix types

* Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`
 2023-04-17 09:25:00 +01:00
Michael Telatynski
daad630827 Conform more of the codebase to strictNullChecks (#10602) 
* Conform more of the codebase to `strictNullChecks`

* Conform more of the codebase to `strictNullChecks`

* Fix types
 2023-04-17 08:31:58 +01:00
Michael Telatynski
439759a1da Relate field validation tooltip via aria-describedby (#10522) 
* Relate field validation tooltip via aria-describedby

* Iterate
 2023-04-14 14:15:26 +00:00
Michael Telatynski
605ef084ec Conform more of the codebase to strictNullChecks (#10573) 
* Conform more of the codebase to `strictNullChecks`

* Iterate
 2023-04-13 08:52:57 +01:00
Michael Telatynski
d2066ba5f5 Improve accessibility of font slider (#10473) 
* Clamp font size when disabling "Use custom size"

* Switch Slider to use a semantic input range element

* Iterate

* delint

* delint

* snapshot

* Iterate

* Iterate

* Fix step size

* Add focus outline to slider

* Derp
 2023-04-12 10:57:31 +00:00
Neeraj Vageele
99a375e354 bind html with switch for manage extension setting (#10553) 
option

Co-authored-by: Neeraj <neerajv@thirdrocktechkno.com>
 2023-04-11 05:13:52 +00:00
Michael Telatynski
a47b3eb0ee Apply strictNullChecks to src/components/views/elements/* (#10462 
* Apply `strictNullChecks` to `src/components/views/elements/*`

* Iterate

* Iterate

* Iterate

* Apply `strictNullChecks` to `src/components/views/elements/*`

* Iterate

* Iterate

* Iterate

* Update snapshot
 2023-03-29 08:23:54 +01:00
Kerry
ae50eee135 Apply strictNullChecks to src/utils/pillify.tsx (#10456) 
* apply strictNullChecks to src/utils/pillify.tsx

* include change to utility

* apply strictNullChecks to src/utils/permalinks
 2023-03-28 10:07:49 +13:00
Michael Telatynski
c225b8ec29 Conform more code to strictNullChecks (#10444 
* Conform more code to `strictNullChecks`

* Fix tests

* Fix tests
 2023-03-27 08:01:09 +01:00
Suguru Hirahara
8e1b9f46d4 Set expected value of line-height to expanded generic event list summary (GELS) spacer on IRC layout (#10211) 
* Set expected line height to an expanded GELS line on IRC layout, add a test
* Add a test for compact modern/group layout
* Create a new test category on timeline.spec.ts
* Rename the class name as 'spacer'
* Add a test for GELS' spacer on bubble layout
---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Germain <germain@souquet.com>
 2023-03-24 12:57:32 +00:00
Michael Weimann
3eb6a55b93 Tweak pill UI (#10417) 2023-03-22 13:27:24 +01:00
Michael Weimann
96d1b74ffc Pillify event permalinks (#10392) 2023-03-21 10:23:20 +01:00
Michael Telatynski
1c9ea423c9 Conform more code to strictNullChecks (#10374) 
* Apply `strictNullChecks` to `src/components/views/room_settings/*`

* Restore tsconfig.json

* Conform more code to `strictNullChecks`

* Iterate

* Update matrix-widget-api

* Conform more code to `strictNullChecks`
 2023-03-16 11:07:29 +00:00
Michael Telatynski
ad65b4e444 Apply strictNullChecks to src/components/views/room_settings/* (#10366 
* Apply `strictNullChecks` to `src/components/views/room_settings/*`

* Restore tsconfig.json
 2023-03-15 08:39:02 +00:00
Michael Telatynski
e3930fb8b0 Show all labs even if incompatible, with appropriate tooltip explaining requirements (#10369) 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
 2023-03-15 08:37:41 +00:00
Kerry
209b65243a Enable "jsx-a11y/alt-text" and "jsx-a11y/label-has-associated-control" lint rules (#10361) 
* enable "jsx-a11y/alt-text" lint rule

* enable "jsx-a11y/label-has-associated-control"
 2023-03-14 21:25:11 +00:00
Michael Telatynski
503df62191 Conform more of the codebase to strictNullChecks (#10358 
* Conform more of the codebase to `strictNullChecks`

* Fix types

* Iterate

* Iterate
 2023-03-13 15:07:20 +00:00
Michael Telatynski
127a3b667c Conform more of the codebase to strictNullChecks (#10350 
* Conform more of the codebase to `strictNullChecks`

* Iterate

* Generics ftw

* Iterate
 2023-03-10 14:55:06 +00:00
Michael Weimann
85e8d27697 Extract avatars from permalink hook (#10328) 2023-03-09 12:48:36 +01:00
Michael Telatynski
80fc0997a4 Explicitly specify all children props (#10312) 2023-03-08 13:28:07 +00:00