Fix message edition and reply when multiple rooms at displayed the same moment (#31280)
* feat: implement `ExtrasApi#setRoomIdsForSpace` * fix: message reply with multiple room views * fix: message edition when multiple rooms are displayed * test: check that the view room action is not dispatch when replying * test: check that the view room action is not dispatch when editing * refactor: use `ExtraApis#getVisibleRoomBySpaceKey` instead of `ExtraApis#setRoomIdsForSpace` * test: update tests to use `getVisibleRoomBySpaceKey`
This commit is contained in:
@@ -1207,7 +1207,13 @@ export class RoomView extends React.Component<IRoomProps, IRoomState> {
|
||||
case Action.EditEvent: {
|
||||
// Quit early if we're trying to edit events in wrong rendering context
|
||||
if (payload.timelineRenderingType !== this.state.timelineRenderingType) return;
|
||||
if (payload.event && payload.event.getRoomId() !== this.state.roomId) {
|
||||
|
||||
const roomId: string | undefined = payload.event?.getRoomId();
|
||||
|
||||
if (payload.event && roomId !== this.state.roomId) {
|
||||
// if the room is displayed in a module, we don't want to change the room view
|
||||
if (roomId && this.roomViewStore.isRoomDisplayedInModule(roomId)) return;
|
||||
|
||||
// If the event is in a different room (e.g. because the event to be edited is being displayed
|
||||
// in the results of an all-rooms search), we need to view that room first.
|
||||
defaultDispatcher.dispatch<ViewRoomPayload>({
|
||||
|
||||
Reference in New Issue
Block a user