From e44ca88a7edc4d047ea625d30d47bf911961dc71 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Gy=C3=B6ngy=C3=B6si?= Date: Thu, 13 Mar 2025 10:46:29 +0100 Subject: [PATCH] Change ToggleHiddenEventVisibility & GoToHome KeyBindingActions (#29374) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The current keyboard shortcuts for GoToHome and ToggleHiddenEventVisibility are: | | other | macOS | |----------------------------- |-------------- |-------------- | | GoToHome | Ctrl–Alt–H | Ctrl–Shift–H | | ToggleHiddenEventVisibility | Ctrl–Shift–H | Cmd–Shift–H | This removes both distinctions for macOS in order ToggleHiddenEventVisibility not to conflict with... 1. the built-in Safari keyboard shortcut for opening the Home page (Cmd–Shift–H) 2. the KeyBindingAction for GoToHome. Co-authored-by: Florian Duros --- src/accessibility/KeyboardShortcuts.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/accessibility/KeyboardShortcuts.ts b/src/accessibility/KeyboardShortcuts.ts index d5c32d6d8d..da0097f4b2 100644 --- a/src/accessibility/KeyboardShortcuts.ts +++ b/src/accessibility/KeyboardShortcuts.ts @@ -521,8 +521,7 @@ export const KEYBOARD_SHORTCUTS: IKeyboardShortcuts = { [KeyBindingAction.GoToHome]: { default: { ctrlKey: true, - altKey: !IS_MAC, - shiftKey: IS_MAC, + altKey: true, key: Key.H, }, displayName: _td("keyboard|go_home_view"), @@ -585,7 +584,7 @@ export const KEYBOARD_SHORTCUTS: IKeyboardShortcuts = { }, [KeyBindingAction.ToggleHiddenEventVisibility]: { default: { - ctrlOrCmdKey: true, + ctrlKey: true, shiftKey: true, key: Key.H, },