Revert "A11y: move focus to right panel when opened" (#30999)
* Revert "A11y: move focus to right panel when opened (#30553)"
This reverts commit 0c498a66b1.
* test(e2e): update test
This commit is contained in:
@@ -34,7 +34,6 @@ import { Action } from "../../dispatcher/actions";
|
||||
import { type XOR } from "../../@types/common";
|
||||
import ExtensionsCard from "../views/right_panel/ExtensionsCard";
|
||||
import MemberListView from "../views/rooms/MemberList/MemberListView";
|
||||
import { _t } from "../../languageHandler";
|
||||
|
||||
interface BaseProps {
|
||||
overwriteCard?: IRightPanelCard; // used to display a custom card and ignoring the RightPanelStore (used for UserView)
|
||||
@@ -65,7 +64,6 @@ interface IState {
|
||||
export default class RightPanel extends React.Component<Props, IState> {
|
||||
public static contextType = MatrixClientContext;
|
||||
declare public context: React.ContextType<typeof MatrixClientContext>;
|
||||
private ref = React.createRef<HTMLDivElement>();
|
||||
|
||||
public constructor(props: Props) {
|
||||
super(props);
|
||||
@@ -84,7 +82,6 @@ export default class RightPanel extends React.Component<Props, IState> {
|
||||
public componentDidMount(): void {
|
||||
this.context.on(RoomStateEvent.Members, this.onRoomStateMember);
|
||||
RightPanelStore.instance.on(UPDATE_EVENT, this.onRightPanelStoreUpdate);
|
||||
this.ref.current?.focus();
|
||||
}
|
||||
|
||||
public componentWillUnmount(): void {
|
||||
@@ -122,13 +119,7 @@ export default class RightPanel extends React.Component<Props, IState> {
|
||||
};
|
||||
|
||||
private onRightPanelStoreUpdate = (): void => {
|
||||
const oldPhase = this.state.phase;
|
||||
const newState = RightPanel.getDerivedStateFromProps(this.props) as IState;
|
||||
this.setState({ ...newState });
|
||||
|
||||
if (oldPhase !== newState.phase) {
|
||||
this.ref.current?.focus();
|
||||
}
|
||||
this.setState({ ...(RightPanel.getDerivedStateFromProps(this.props) as IState) });
|
||||
};
|
||||
|
||||
private onClose = (): void => {
|
||||
@@ -289,14 +280,7 @@ export default class RightPanel extends React.Component<Props, IState> {
|
||||
}
|
||||
|
||||
return (
|
||||
<aside
|
||||
aria-label={_t("right_panel|title")}
|
||||
ref={this.ref}
|
||||
className="mx_RightPanel"
|
||||
id="mx_RightPanel"
|
||||
data-testid="right-panel"
|
||||
tabIndex={-1}
|
||||
>
|
||||
<aside className="mx_RightPanel" id="mx_RightPanel" data-testid="right-panel">
|
||||
{card}
|
||||
</aside>
|
||||
);
|
||||
|
||||
@@ -1917,7 +1917,6 @@
|
||||
"thread_list": {
|
||||
"context_menu_label": "Thread options"
|
||||
},
|
||||
"title": "Right panel",
|
||||
"video_room_chat": {
|
||||
"title": "Chat"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user