Add tabs to the right panel (#12672)
* Create new method for header button behaviour With the introduction of tabs, the behaviour of the header buttons is changed as follows: - Close any right panel if open - Open the correct right panel if no panel was open before The old method (and behaviour) is retained as showOrHidePhase. * Implement tabs in the right panel There are three tabs: Info, People and Threads * Remove unwanted code from RoomSummaryCard - Remove the menu item for opening the memberlist since that is now taken of by the tabs. - Remove the close button * Remove code for focusing close button from tac item See https://github.com/matrix-org/matrix-react-sdk/pull/12410 There's no longer a close button to focus so we instead focus the thread tab. This is done in RightPaneltabs.tsx so we just need to remove this code. * Introduce a room info icon to the header This was previously present in the legacy room header but not in the new header. * BaseCard changes - Adds id, ariaLabelledBy and role props to implement tab accessibility. - Adds hideHeaderButtons prop to hide header buttons (think back and close buttons). - Change confusing header rendering code: header is not rendered ONLY when no header is passed AND hideHeaderButtons is true. * Refactor repeated code into function Created a new function createSpaceScopeHeader which returns the component if the room is a space room. Previously this code was duplicated in every component that uses SpaceScopeHeader component. * Pass BaseCard attributes and use helper function Actually using the code from the last two commits * Add, update and remove tests/screenshots/snapshots * Fix distance between search bar and tabs * Update compound * Update screenshots/snapshots
This commit is contained in:
@@ -236,6 +236,23 @@ export default class RightPanelStore extends ReadyWatchingStore {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* If the right panel is open, it is closed.
|
||||
* If the right panel is closed, it is opened with `phase`.
|
||||
*
|
||||
* This is different from showOrHidePhase which only closes the panel
|
||||
* if the panel was already showing the phase passed as argument.
|
||||
* @see showOrHidePhase
|
||||
* @param phase The right panel phase.
|
||||
*/
|
||||
public showOrHidePanel(phase: RightPanelPhases): void {
|
||||
if (!this.isOpen) {
|
||||
this.setCard({ phase });
|
||||
} else {
|
||||
this.togglePanel(null);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Helper to show a right panel phase.
|
||||
* If the UI is already showing that phase, the right panel will be hidden.
|
||||
@@ -245,7 +262,7 @@ export default class RightPanelStore extends ReadyWatchingStore {
|
||||
* @param phase The right panel phase.
|
||||
* @param cardState The state within the phase.
|
||||
*/
|
||||
public showOrHidePanel(phase: RightPanelPhases, cardState?: Partial<IRightPanelCardState>): void {
|
||||
public showOrHidePhase(phase: RightPanelPhases, cardState?: Partial<IRightPanelCardState>): void {
|
||||
if (this.currentCard.phase == phase && !cardState && this.isOpen) {
|
||||
this.togglePanel(null);
|
||||
} else {
|
||||
|
||||
@@ -32,6 +32,6 @@ export const onView3pidInvite = (payload: ActionPayload, rightPanelStore: RightP
|
||||
state: { memberInfoEvent: payload.event },
|
||||
});
|
||||
} else {
|
||||
rightPanelStore.showOrHidePanel(RightPanelPhases.RoomMemberList);
|
||||
rightPanelStore.showOrHidePhase(RightPanelPhases.RoomMemberList);
|
||||
}
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user