nikrozman/element-web
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Rename callback on E2eSetup component (#31274)

Browse Source 
* Rename callback on E2eSetup component

`BaseDialog.onFinished` is unused when `hasCancel=false`, so this callback is
only used when the user clicks cancel. For clarity, rename it.

* Test for cancellation behaviour
This commit is contained in:
Richard van der Hoff
2025-11-20 18:17:51 +00:00
committed by GitHub
parent 64130a018b
commit c203f02731
5 changed files with 52 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/unit-tests/components/views/dialogs/security/InitialCryptoSetupDialog-test.tsx
View File

@@ -31,11 +31,9 @@ describe("InitialCryptoSetupDialog", () => {
});
it("should show a spinner while the setup is in progress", async () => {
const onFinished = jest.fn();
storeMock.getStatus.mockReturnValue("in_progress");
render(<InitialCryptoSetupDialog onFinished={onFinished} />);
render(<InitialCryptoSetupDialog onCancelled={jest.fn()} />);
expect(screen.getByTestId("spinner")).toBeInTheDocument();
});
@@ -43,16 +41,15 @@ describe("InitialCryptoSetupDialog", () => {
it("should display an error if setup has failed", async () => {
storeMock.getStatus.mockReturnValue("error");
render(<InitialCryptoSetupDialog onFinished={jest.fn()} />);
render(<InitialCryptoSetupDialog onCancelled={jest.fn()} />);
await expect(await screen.findByRole("button", { name: "Retry" })).toBeInTheDocument();
});
it("calls retry when retry button pressed", async () => {
const onFinished = jest.fn();
storeMock.getStatus.mockReturnValue("error");
render(<InitialCryptoSetupDialog onFinished={onFinished} />);
render(<InitialCryptoSetupDialog onCancelled={jest.fn()} />);
await userEvent.click(await screen.findByRole("button", { name: "Retry" }));