Rename callback on E2eSetup component (#31274)
* Rename callback on E2eSetup component `BaseDialog.onFinished` is unused when `hasCancel=false`, so this callback is only used when the user clicks cancel. For clarity, rename it. * Test for cancellation behaviour
This commit is contained in:
committed by
GitHub
parent
64130a018b
commit
c203f02731
35
test/unit-tests/components/structures/auth/E2eSetup-test.tsx
Normal file
35
test/unit-tests/components/structures/auth/E2eSetup-test.tsx
Normal file
@@ -0,0 +1,35 @@
|
||||
/*
|
||||
Copyright 2025 Element Creations Ltd.
|
||||
|
||||
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
||||
Please see LICENSE files in the repository root for full details.
|
||||
*/
|
||||
|
||||
import React from "react";
|
||||
import { render } from "jest-matrix-react";
|
||||
import { mocked } from "jest-mock";
|
||||
|
||||
import E2eSetup from "../../../../../src/components/structures/auth/E2eSetup.tsx";
|
||||
import { InitialCryptoSetupStore } from "../../../../../src/stores/InitialCryptoSetupStore.ts";
|
||||
|
||||
afterEach(() => jest.restoreAllMocks());
|
||||
|
||||
describe("LeftPanel", () => {
|
||||
it("should call `onCancelled` when the user clicks the cancel button", () => {
|
||||
const mockInitialCryptoSetupStore = {
|
||||
getStatus: jest.fn(),
|
||||
on: jest.fn(),
|
||||
off: jest.fn(),
|
||||
};
|
||||
jest.spyOn(InitialCryptoSetupStore, "sharedInstance").mockReturnValue(mockInitialCryptoSetupStore as any);
|
||||
|
||||
// We need the setup process to have failed, for the dialog to present a cancel button.
|
||||
mocked(mockInitialCryptoSetupStore.getStatus).mockReturnValue("error");
|
||||
|
||||
const onCancelled = jest.fn();
|
||||
const { getByRole } = render(<E2eSetup onCancelled={onCancelled} />);
|
||||
|
||||
getByRole("button", { name: "Cancel" }).click();
|
||||
expect(onCancelled).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
@@ -31,11 +31,9 @@ describe("InitialCryptoSetupDialog", () => {
|
||||
});
|
||||
|
||||
it("should show a spinner while the setup is in progress", async () => {
|
||||
const onFinished = jest.fn();
|
||||
|
||||
storeMock.getStatus.mockReturnValue("in_progress");
|
||||
|
||||
render(<InitialCryptoSetupDialog onFinished={onFinished} />);
|
||||
render(<InitialCryptoSetupDialog onCancelled={jest.fn()} />);
|
||||
|
||||
expect(screen.getByTestId("spinner")).toBeInTheDocument();
|
||||
});
|
||||
@@ -43,16 +41,15 @@ describe("InitialCryptoSetupDialog", () => {
|
||||
it("should display an error if setup has failed", async () => {
|
||||
storeMock.getStatus.mockReturnValue("error");
|
||||
|
||||
render(<InitialCryptoSetupDialog onFinished={jest.fn()} />);
|
||||
render(<InitialCryptoSetupDialog onCancelled={jest.fn()} />);
|
||||
|
||||
await expect(await screen.findByRole("button", { name: "Retry" })).toBeInTheDocument();
|
||||
});
|
||||
|
||||
it("calls retry when retry button pressed", async () => {
|
||||
const onFinished = jest.fn();
|
||||
storeMock.getStatus.mockReturnValue("error");
|
||||
|
||||
render(<InitialCryptoSetupDialog onFinished={onFinished} />);
|
||||
render(<InitialCryptoSetupDialog onCancelled={jest.fn()} />);
|
||||
|
||||
await userEvent.click(await screen.findByRole("button", { name: "Retry" }));
|
||||
|
||||
|
||||
Reference in New Issue
Block a user