From bd142412e5dc4b62a69ceeae77038d8c237aa9d5 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Thu, 22 May 2025 10:32:23 +0100 Subject: [PATCH] Downstream test element-modules in merge queue (#29899) * Downstream test element-modules in merge queue Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Typo Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update cache key to be arch-aware Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- .github/workflows/end-to-end-tests.yaml | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/.github/workflows/end-to-end-tests.yaml b/.github/workflows/end-to-end-tests.yaml index b2acfd88b6..b2d49d7703 100644 --- a/.github/workflows/end-to-end-tests.yaml +++ b/.github/workflows/end-to-end-tests.yaml @@ -157,9 +157,8 @@ jobs: uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4 id: playwright-cache with: - path: | - ~/.cache/ms-playwright - key: ${{ runner.os }}-playwright-${{ steps.playwright.outputs.version }} + path: ~/.cache/ms-playwright + key: ${{ runner.os }}-${{ runner.arch }}-playwright-${{ steps.playwright.outputs.version }} - name: Install Playwright browsers if: steps.playwright-cache.outputs.cache-hit != 'true' @@ -186,9 +185,19 @@ jobs: path: blob-report retention-days: 1 + downstream-modules: + name: Downstream Playwright tests [element-modules] + needs: build + if: inputs.skip != true && github.event_name == 'merge_group' + uses: element-hq/element-modules/.github/workflows/reusable-playwright-tests.yml@main + with: + webapp-artifact: webapp + complete: name: end-to-end-tests - needs: playwright + needs: + - playwright + - downstream-modules if: always() runs-on: ubuntu-24.04 steps: @@ -232,5 +241,5 @@ jobs: path: playwright-report retention-days: 14 - - if: needs.playwright.result != 'skipped' && needs.playwright.result != 'success' + - if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') run: exit 1