Fix platform settings race condition and make auto-launch tri-state (#30977)
* Fix race condition with platform settings not being read correctly Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Allow Desktop app to be auto-started minimised or focused Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * i18n Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Use onChange prop Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update res/css/views/elements/_SettingsDropdown.pcss Co-authored-by: Florian Duros <florianduros@element.io> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Florian Duros <florianduros@element.io>
This commit is contained in:
committed by
GitHub
parent
3098eba4f2
commit
bc7b50f97c
@@ -374,11 +374,13 @@ export default class ElectronPlatform extends BasePlatform {
|
||||
return this.supportedSettings?.[settingName] === true;
|
||||
}
|
||||
|
||||
public getSettingValue(settingName: string): Promise<any> {
|
||||
public async getSettingValue(settingName: string): Promise<any> {
|
||||
await this.initialised;
|
||||
return this.electron.getSettingValue(settingName);
|
||||
}
|
||||
|
||||
public setSettingValue(settingName: string, value: any): Promise<void> {
|
||||
public async setSettingValue(settingName: string, value: any): Promise<void> {
|
||||
await this.initialised;
|
||||
return this.electron.setSettingValue(settingName, value);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user