nikrozman/element-web
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Add option to hide pinned message banner in room view (#31296)

Browse Source 
* feat: add `hidePinnedMessageBanner` to room view

* test: add test for `hidePinnedMessageBanner`
This commit is contained in:
Florian Duros
2025-11-21 14:45:22 +01:00
committed by GitHub
parent 81c375007e
commit a79f6e7aa5
3 changed files with 421 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/unit-tests/components/structures/RoomView-test.tsx
View File

@@ -77,6 +77,7 @@ import { CallStore } from "../../../../src/stores/CallStore.ts";
import MediaDeviceHandler, { MediaDeviceKindEnum } from "../../../../src/MediaDeviceHandler.ts";
import Modal, { type ComponentProps } from "../../../../src/Modal.tsx";
import ErrorDialog from "../../../../src/components/views/dialogs/ErrorDialog.tsx";
import * as pinnedEventHooks from "../../../../src/hooks/usePinnedEvents";
// Used by group calls
jest.spyOn(MediaDeviceHandler, "getDevices").mockResolvedValue({
@@ -124,6 +125,11 @@ describe("RoomView", () => {
afterEach(() => {
unmockPlatformPeg();
jest.clearAllMocks();
// Can't jest.restoreAllMocks() because some tests will break
jest.spyOn(pinnedEventHooks, "usePinnedEvents").mockRestore();
jest.spyOn(pinnedEventHooks, "useSortedFetchedPinnedEvents").mockRestore();
cleanup();
});
@@ -298,6 +304,35 @@ describe("RoomView", () => {
expect(asFragment()).toMatchSnapshot();
});
it("should hide the pinned message banner when hidePinnedMessageBanner=true", async () => {
// Join the room
jest.spyOn(room, "getMyMembership").mockReturnValue(KnownMembership.Join);
const pinnedEvent = new MatrixEvent({
type: EventType.RoomMessage,
sender: "@alice:example.org",
content: {
body: "First pinned message",
msgtype: "m.text",
},
room_id: room.roomId,
origin_server_ts: 0,
event_id: "$eventId",
});
jest.spyOn(pinnedEventHooks, "usePinnedEvents").mockReturnValue([pinnedEvent.getId()!]);
jest.spyOn(pinnedEventHooks, "useSortedFetchedPinnedEvents").mockReturnValue([pinnedEvent]);
const { asFragment, rerender } = await mountRoomView(undefined);
// Check that the pinned message banner is rendered
await expect(screen.findByTestId("pinned-message-banner")).resolves.toBeTruthy();
// Now rerender with hidePinnedMessagesBanner=true
rerender(<RoomView threepidInvite={undefined} forceTimeline={false} hidePinnedMessageBanner={true} />);
// Check that the pinned message banner is not rendered
await expect(screen.findByTestId("pinned-message-banner")).rejects.toThrow();
expect(asFragment()).toMatchSnapshot();
});
describe("invites", () => {
beforeEach(() => {
const member = new RoomMember(room.roomId, cli.getSafeUserId());