nikrozman/element-web
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Re-order primary filters (#29957)

Browse Source 
* Re-order primary filters

to match EX

* Update tests

* Update screenshots

* Try to make screenshot deterministic

* Just use the screenshot the CI spits out

* Try again

* Another screenshot
This commit is contained in:
David Baker
2025-05-15 14:15:24 +01:00
committed by GitHub
parent c309cc8bfa
commit 9642af9930
11 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/unit-tests/components/viewmodels/roomlist/RoomListViewModel-test.tsx
View File

@@ -73,7 +73,7 @@ describe("RoomListViewModel", () => {
// should have 4 filters
expect(vm.current.primaryFilters).toHaveLength(4);
// check the order
for (const [i, name] of ["Unreads", "Favourites", "People", "Rooms"].entries()) {
for (const [i, name] of ["Unreads", "People", "Rooms", "Favourites"].entries()) {
expect(vm.current.primaryFilters[i].name).toEqual(name);
expect(vm.current.primaryFilters[i].active).toEqual(false);
}

52
test/unit-tests/components/views/rooms/RoomListPanel/__snapshots__/RoomListPanel-test.tsx.snap
View File

@@ -73,19 +73,6 @@ exports[`<RoomListPanel /> should not render the RoomListSearch component when U
Unreads
</button>
</li>
<li
aria-selected="false"
role="option"
>
<button
aria-selected="false"
class="_chat-filter_5qdp0_8"
role="button"
tabindex="0"
>
Favourites
</button>
</li>
<li
aria-selected="false"
role="option"
@@ -112,6 +99,19 @@ exports[`<RoomListPanel /> should not render the RoomListSearch component when U
Rooms
</button>
</li>
<li
aria-selected="false"
role="option"
>
<button
aria-selected="false"
class="_chat-filter_5qdp0_8"
role="button"
tabindex="0"
>
Favourites
</button>
</li>
</ul>
<div
aria-label="Secondary filters"
@@ -328,19 +328,6 @@ exports[`<RoomListPanel /> should render the RoomListSearch component when UICom
Unreads
</button>
</li>
<li
aria-selected="false"
role="option"
>
<button
aria-selected="false"
class="_chat-filter_5qdp0_8"
role="button"
tabindex="0"
>
Favourites
</button>
</li>
<li
aria-selected="false"
role="option"
@@ -367,6 +354,19 @@ exports[`<RoomListPanel /> should render the RoomListSearch component when UICom
Rooms
</button>
</li>
<li
aria-selected="false"
role="option"
>
<button
aria-selected="false"
class="_chat-filter_5qdp0_8"
role="button"
tabindex="0"
>
Favourites
</button>
</li>
</ul>
<div
aria-label="Secondary filters"