chore: move api key to config, fix gif picker css

config.sample.json

@@ -47,5 +47,6 @@
         "participant_limit": 8,
         "brand": "Element Call"
     },
-    "map_style_url": "https://api.maptiler.com/maps/streets/style.json?key=fU3vlMsMn4Jb6dnEIFsx"
+    "map_style_url": "https://api.maptiler.com/maps/streets/style.json?key=fU3vlMsMn4Jb6dnEIFsx",
+    "giphy_api_key": "x"
 }

res/css/views/gifpicker/_GifPicker.pcss

@@ -102,7 +102,12 @@ Please see LICENSE files in the repository root for full details.
 
 .mx_GifPicker_search_icon {
     width: 16px;
+    height: 16px;
+    border: none;
+    background-color: inherit;
     margin: 8px;
+    padding: 8px;
+    align-self: center;
 }
 
 .mx_GifPicker_search_icon:not(.mx_GifPicker_search_clear) {

src/IConfigOptions.ts

@@ -55,6 +55,7 @@ export interface IConfigOptions {
     force_verification?: boolean; // if true, users must verify new logins
 
     map_style_url?: string; // for location-shared maps
+    giphy_api_key?: string; // gif picker
 
     embedded_pages?: {
         welcome_url?: string;

src/components/views/gifpicker/GifPicker.tsx

@@ -10,21 +10,28 @@ import dis from "../../../dispatcher/dispatcher";
 import { Action } from "../../../dispatcher/actions";
 import { ComposerInsertPayload } from "../../../dispatcher/payloads/ComposerInsertPayload";
 import { IEventRelation } from "matrix-js-sdk/src/matrix";
+import { getGiphyApiKey } from "../../../utils/WellKnownUtils";
+import { TimelineRenderingType } from "../../../contexts/RoomContext";
 
-const GIPHY_API_KEY = "x"; // TODO: Move to config
+const GIPHY_API_KEY = getGiphyApiKey();
-const gf = new GiphyFetch(GIPHY_API_KEY);
+const gf = new GiphyFetch(GIPHY_API_KEY!);
 
 interface IProps {
     onGifSelect: (url: string) => void;
     onFinished: () => void;
     roomId: string;
     relation?: IEventRelation;
-    timelineRenderingType: string;
+    timelineRenderingType: TimelineRenderingType;
 }
 
 export const GifPicker: React.FC<IProps> = ({ onGifSelect, onFinished, roomId, relation, timelineRenderingType }) => {
     const [searchQuery, setSearchQuery] = useState("");
-    
+
+    if (!GIPHY_API_KEY) {
+        console.error("GIPHY API key is missing in the configuration.");
+        return null; // Return null if the API key is not configured
+    }
+
     const fetchGifs = (offset: number) => {
         if (!searchQuery) {
             return gf.trending({ offset, limit: 10 });
@@ -53,8 +60,8 @@ export const GifPicker: React.FC<IProps> = ({ onGifSelect, onFinished, roomId, r
                 [file],
                 roomId,
                 relation,
-                MatrixClientPeg.get(),
+                MatrixClientPeg.safeGet(),
-                timelineRenderingType
+                timelineRenderingType as TimelineRenderingType
             );
 
             onFinished();

src/components/views/rooms/GifButton.tsx

@@ -15,6 +15,7 @@ import GifPicker from "../gifpicker/GifPicker";
 import { CollapsibleButton } from "./CollapsibleButton";
 import { OverflowMenuContext } from "./MessageComposerButtons";
 import { IEventRelation } from "matrix-js-sdk/src/matrix";
+import { TimelineRenderingType } from "../../../contexts/RoomContext";
 
 interface IGifButtonProps {
     addGif: (unicode: string) => boolean;
@@ -22,7 +23,7 @@ interface IGifButtonProps {
     className?: string;
     roomId: string;
     relation?: IEventRelation;
-    timelineRenderingType: string;
+    timelineRenderingType: TimelineRenderingType;
 }
 
 export function GifButton({ addGif, menuPosition, className, roomId, relation, timelineRenderingType }: IGifButtonProps): JSX.Element {

src/utils/WellKnownUtils.ts

@@ -8,12 +8,14 @@ Please see LICENSE files in the repository root for full details.
 
 import { type IClientWellKnown, type MatrixClient } from "matrix-js-sdk/src/matrix";
 import { UnstableValue } from "matrix-js-sdk/src/NamespacedValue";
+import SdkConfig from "../SdkConfig";
 
 const CALL_BEHAVIOUR_WK_KEY = "io.element.call_behaviour";
 const E2EE_WK_KEY = "io.element.e2ee";
 const E2EE_WK_KEY_DEPRECATED = "im.vector.riot.e2ee";
 export const TILE_SERVER_WK_KEY = new UnstableValue("m.tile_server", "org.matrix.msc3488.tile_server");
 const EMBEDDED_PAGES_WK_PROPERTY = "io.element.embedded_pages";
+export const GIPHY_WK_KEY = ""
 
 /* eslint-disable camelcase */
 export interface ICallBehaviourWellKnown {
@@ -38,6 +40,10 @@ export interface ITileServerWellKnown {
     map_style_url?: string;
 }
 
+export interface IGiphyKeyWellKnown {
+    giphy_api_key?: string;
+}
+
 export interface IEmbeddedPagesWellKnown {
     home_url?: string;
 }
@@ -67,6 +73,14 @@ export function tileServerFromWellKnown(clientWellKnown?: IClientWellKnown | und
     return clientWellKnown?.[TILE_SERVER_WK_KEY.name] ?? clientWellKnown?.[TILE_SERVER_WK_KEY.altName];
 }
 
+export function getGiphyKeyWellKnown(matrixClient: MatrixClient): IGiphyKeyWellKnown | undefined {
+    return giphyKeyFromWellKnown(matrixClient.getClientWellKnown());
+}
+
+export function giphyKeyFromWellKnown(clientWellKnown?: IClientWellKnown | undefined): IGiphyKeyWellKnown {
+    return clientWellKnown?.[TILE_SERVER_WK_KEY.name] ?? clientWellKnown?.[TILE_SERVER_WK_KEY.altName];
+}
+
 export function getEmbeddedPagesWellKnown(matrixClient: MatrixClient | undefined): IEmbeddedPagesWellKnown | undefined {
     return embeddedPagesFromWellKnown(matrixClient?.getClientWellKnown());
 }
@@ -99,3 +113,8 @@ export function getSecureBackupSetupMethods(matrixClient: MatrixClient): SecureB
     }
     return wellKnown["secure_backup_setup_methods"];
 }
+
+export function getGiphyApiKey(): string | undefined {
+    const config = SdkConfig.get();
+    return config?.giphy_api_key;
+}

tsconfig.json

@@ -1,6 +1,7 @@
 {
     "compilerOptions": {
         "allowImportingTsExtensions": true,
+        "noEmit": true,
         "experimentalDecorators": false,
         "emitDecoratorMetadata": false,
         "resolveJsonModule": true,

webpack.config.js

@@ -599,6 +599,7 @@ module.exports = (env, argv) => {
                 templateParameters: {
                     og_image_url: ogImageUrl,
                     csp_extra_source: process.env.CSP_EXTRA_SOURCE ?? "",
+                    csp_img_src: "'self' blob: data: https://media.giphy.com media.giphy.com https://media2.giphy.com media2.giphy.com https://media3.giphy.com media3.giphy.com",
                 },
             }),