Comply with noImplicitAny (#9940)

* Stash noImplicitAny work

* Stash

* Fix imports

* Iterate

* Fix tests

* Delint

* Fix tests

src/accessibility/KeyboardShortcutUtils.ts

@@ -27,6 +27,7 @@ import {
     KEYBOARD_SHORTCUTS,
     MAC_ONLY_SHORTCUTS,
 } from "./KeyboardShortcuts";
+import { IBaseSetting } from "../settings/Settings";
 
 /**
  * This function gets the keyboard shortcuts that should be presented in the UI
@@ -103,7 +104,7 @@ export const getKeyboardShortcuts = (): IKeyboardShortcuts => {
             return true;
         })
         .reduce((o, key) => {
-            o[key] = KEYBOARD_SHORTCUTS[key];
+            o[key as KeyBindingAction] = KEYBOARD_SHORTCUTS[key as KeyBindingAction];
             return o;
         }, {} as IKeyboardShortcuts);
 };
@@ -112,7 +113,10 @@ export const getKeyboardShortcuts = (): IKeyboardShortcuts => {
  * Gets keyboard shortcuts that should be presented to the user in the UI.
  */
 export const getKeyboardShortcutsForUI = (): IKeyboardShortcuts => {
-    const entries = [...Object.entries(getUIOnlyShortcuts()), ...Object.entries(getKeyboardShortcuts())];
+    const entries = [...Object.entries(getUIOnlyShortcuts()), ...Object.entries(getKeyboardShortcuts())] as [
+        KeyBindingAction,
+        IBaseSetting<KeyCombo>,
+    ][];
 
     return entries.reduce((acc, [key, value]) => {
         acc[key] = value;
@@ -120,11 +124,11 @@ export const getKeyboardShortcutsForUI = (): IKeyboardShortcuts => {
     }, {} as IKeyboardShortcuts);
 };
 
-export const getKeyboardShortcutValue = (name: string): KeyCombo | undefined => {
+export const getKeyboardShortcutValue = (name: KeyBindingAction): KeyCombo | undefined => {
     return getKeyboardShortcutsForUI()[name]?.default;
 };
 
-export const getKeyboardShortcutDisplayName = (name: string): string | undefined => {
+export const getKeyboardShortcutDisplayName = (name: KeyBindingAction): string | undefined => {
     const keyboardShortcutDisplayName = getKeyboardShortcutsForUI()[name]?.displayName;
-    return keyboardShortcutDisplayName && _t(keyboardShortcutDisplayName);
+    return keyboardShortcutDisplayName && _t(keyboardShortcutDisplayName as string);
 };

src/accessibility/KeyboardShortcuts.ts

@@ -156,10 +156,8 @@ export enum KeyBindingAction {
 
 type KeyboardShortcutSetting = IBaseSetting<KeyCombo>;
 
-export type IKeyboardShortcuts = {
-    // TODO: We should figure out what to do with the keyboard shortcuts that are not handled by KeybindingManager
-    [k in KeyBindingAction]?: KeyboardShortcutSetting;
-};
+// TODO: We should figure out what to do with the keyboard shortcuts that are not handled by KeybindingManager
+export type IKeyboardShortcuts = Partial<Record<KeyBindingAction, KeyboardShortcutSetting>>;
 
 export interface ICategory {
     categoryLabel?: string;

src/accessibility/RovingTabIndex.tsx

@@ -25,6 +25,7 @@ import React, {
     Reducer,
     Dispatch,
     RefObject,
+    ReactNode,
 } from "react";
 
 import { getKeyBindingsManager } from "../KeyBindingsManager";
@@ -158,8 +159,8 @@ interface IProps {
     handleHomeEnd?: boolean;
     handleUpDown?: boolean;
     handleLeftRight?: boolean;
-    children(renderProps: { onKeyDownHandler(ev: React.KeyboardEvent) });
-    onKeyDown?(ev: React.KeyboardEvent, state: IState);
+    children(renderProps: { onKeyDownHandler(ev: React.KeyboardEvent): void }): ReactNode;
+    onKeyDown?(ev: React.KeyboardEvent, state: IState): void;
 }
 
 export const findSiblingElement = (

src/accessibility/context_menu/StyledMenuItemCheckbox.tsx

@@ -25,7 +25,7 @@ import { getKeyBindingsManager } from "../../KeyBindingsManager";
 
 interface IProps extends React.ComponentProps<typeof StyledCheckbox> {
     label?: string;
-    onChange(); // we handle keyup/down ourselves so lose the ChangeEvent
+    onChange(): void; // we handle keyup/down ourselves so lose the ChangeEvent
     onClose(): void; // gets called after onChange on KeyBindingAction.ActivateSelectedButton
 }
 

src/accessibility/context_menu/StyledMenuItemRadio.tsx

@@ -25,7 +25,7 @@ import { getKeyBindingsManager } from "../../KeyBindingsManager";
 
 interface IProps extends React.ComponentProps<typeof StyledRadioButton> {
     label?: string;
-    onChange(); // we handle keyup/down ourselves so lose the ChangeEvent
+    onChange(): void; // we handle keyup/down ourselves so lose the ChangeEvent
     onClose(): void; // gets called after onChange on KeyBindingAction.Enter
 }
 

src/accessibility/roving/RovingAccessibleButton.tsx

@@ -30,7 +30,7 @@ export const RovingAccessibleButton: React.FC<IProps> = ({ inputRef, onFocus, ..
     return (
         <AccessibleButton
             {...props}
-            onFocus={(event) => {
+            onFocus={(event: React.FocusEvent) => {
                 onFocusInternal();
                 onFocus?.(event);
             }}

src/accessibility/roving/RovingAccessibleTooltipButton.tsx

@@ -31,7 +31,7 @@ export const RovingAccessibleTooltipButton: React.FC<IProps> = ({ inputRef, onFo
     return (
         <AccessibleTooltipButton
             {...props}
-            onFocus={(event) => {
+            onFocus={(event: React.FocusEvent) => {
                 onFocusInternal();
                 onFocus?.(event);
             }}

src/accessibility/roving/RovingTabIndexWrapper.tsx

@@ -14,14 +14,14 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import React from "react";
+import React, { ReactElement } from "react";
 
 import { useRovingTabIndex } from "../RovingTabIndex";
 import { FocusHandler, Ref } from "./types";
 
 interface IProps {
     inputRef?: Ref;
-    children(renderProps: { onFocus: FocusHandler; isActive: boolean; ref: Ref });
+    children(renderProps: { onFocus: FocusHandler; isActive: boolean; ref: Ref }): ReactElement<any, any>;
 }
 
 // Wrapper to allow use of useRovingTabIndex outside of React Functional Components.