Allow the Login screen to use the dark theme (#31293)

* Allow the Login screen to use the dark theme

There is a whole bunch of code dedicated to attempting to force a "light" theme
onto the login view, even if the deployment is configured to prioritise the
dark theme.

Apparently this was done because, in the old days, the
login view looked rubbish with the dark theme, but now it looks fine.

Fixes https://github.com/element-hq/element-web/issues/31292

* Fix up background colour of auth screen in dark theme

In dark theme, the background of the login/register/welcome box needs to be
translucent black rather than translucent white.

To make this work, I've moved the style from inline to CSS, and used a PostCSS
variable to define the colour.

* Fix up Welcome page colours in dark theme

Make the text and image white, not black, in short.

* Fix incorrect merge

that will teach me to use the Github UI to address merge conflicts.
This commit is contained in:
Richard van der Hoff
2025-11-26 07:54:40 +00:00
committed by GitHub
parent 8753a9136f
commit 5f07fbbc1b
14 changed files with 21 additions and 50 deletions

View File

@@ -14,11 +14,6 @@ import { DEFAULT_THEME } from "../../../../src/theme";
describe("ThemeController", () => {
jest.spyOn(SettingsStore, "getValue").mockReturnValue([]);
afterEach(() => {
// reset
ThemeController.isLogin = false;
});
it("returns null when calculatedValue is falsy", () => {
const controller = new ThemeController();
@@ -32,16 +27,6 @@ describe("ThemeController", () => {
).toEqual(null);
});
it("returns light when login flag is set", () => {
const controller = new ThemeController();
ThemeController.isLogin = true;
expect(controller.getValueOverride(SettingLevel.ACCOUNT, "$room:server", "dark", SettingLevel.ACCOUNT)).toEqual(
"light",
);
});
it("returns default theme when value is not a valid theme", () => {
const controller = new ThemeController();