Fix jitsi widget popout (#30908)
* Fix jitsi widget popout Unfortunately I don't think playwright or jest can write a test for something successfully opening a new tab. Fixes https://github.com/element-hq/element-desktop/issues/2527 * On second thoughts, this is probably overkill * Clarify * Add test * Unused import
This commit is contained in:
@@ -476,6 +476,8 @@ export default class AppTile extends React.Component<IProps, IState> {
|
||||
}
|
||||
|
||||
// Delete the widget from the persisted store for good measure.
|
||||
// XXX: This removes persistent elements from the DOM entirely, which feels like
|
||||
// a lot more than this function claims to be doing.
|
||||
PersistedElement.destroyElement(this.persistKey);
|
||||
ActiveWidgetStore.instance.destroyPersistentWidget(
|
||||
this.props.app.id,
|
||||
@@ -586,7 +588,7 @@ export default class AppTile extends React.Component<IProps, IState> {
|
||||
// reset messaging
|
||||
this.resetWidget(this.props);
|
||||
this.iframeParent?.querySelector("iframe")?.remove();
|
||||
this.startMessaging();
|
||||
// iframeParent will now be re-mounted, at which point startMessaging will be called
|
||||
}
|
||||
|
||||
// TODO replace with full screen interactions
|
||||
|
||||
Reference in New Issue
Block a user