Disable file drag-and-drop if insufficient permissions (#30186)

* Disable file drag-and-drop if insufficient permissions Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2025-06-24 14:26:03 +01:00
parent f707bb410e
commit 2b8f95a25b
5 changed files with 94 additions and 7 deletions
--- a/test/unit-tests/components/structures/FileDropTarget-test.tsx
+++ b/test/unit-tests/components/structures/FileDropTarget-test.tsx
@@ -0,0 +1,59 @@
+/*
+Copyright 2025 New Vector Ltd.
+
+SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
+Please see LICENSE files in the repository root for full details.
+*/
+
+import React from "react";
+import { mocked } from "jest-mock";
+import { render, fireEvent } from "jest-matrix-react";
+import { Room } from "matrix-js-sdk/src/matrix";
+
+import FileDropTarget from "../../../../src/components/structures/FileDropTarget.tsx";
+import { stubClient } from "../../../test-utils";
+
+describe("FileDropTarget", () => {
+    let room: Room;
+    beforeEach(() => {
+        const client = stubClient();
+        room = new Room("!roomId:example.com", client, client.getUserId()!);
+        room.currentState.maySendMessage = jest.fn().mockReturnValue(true);
+    });
+
+    it("should render nothing when idle", () => {
+        const element = document.createElement("div");
+        const onFileDrop = jest.fn();
+
+        const { asFragment } = render(<FileDropTarget room={room} onFileDrop={onFileDrop} parent={element} />);
+        expect(asFragment()).toMatchSnapshot();
+    });
+
+    it("should render drop file prompt on mouse over with file if permissions allow", () => {
+        const element = document.createElement("div");
+        const onFileDrop = jest.fn();
+        mocked(room.currentState.maySendMessage).mockReturnValue(true);
+
+        const { asFragment } = render(<FileDropTarget room={room} onFileDrop={onFileDrop} parent={element} />);
+        fireEvent.dragEnter(element, {
+            dataTransfer: {
+                types: ["Files"],
+            },
+        });
+        expect(asFragment()).toMatchSnapshot();
+    });
+
+    it("should not render drop file prompt on mouse over with file if permissions do not allow", () => {
+        const element = document.createElement("div");
+        const onFileDrop = jest.fn();
+        mocked(room.currentState.maySendMessage).mockReturnValue(false);
+
+        const { asFragment } = render(<FileDropTarget room={room} onFileDrop={onFileDrop} parent={element} />);
+        fireEvent.dragEnter(element, {
+            dataTransfer: {
+                types: ["Files"],
+            },
+        });
+        expect(asFragment()).toMatchSnapshot();
+    });
+});
--- a/test/unit-tests/components/structures/snapshots/FileDropTarget-test.tsx.snap
+++ b/test/unit-tests/components/structures/snapshots/FileDropTarget-test.tsx.snap
@@ -0,0 +1,20 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`FileDropTarget should not render drop file prompt on mouse over with file if permissions do not allow 1`] = `<DocumentFragment />`;
+
+exports[`FileDropTarget should render drop file prompt on mouse over with file if permissions allow 1`] = `
+<DocumentFragment>
+  <div
+    class="mx_FileDropTarget"
+  >
+    <img
+      alt=""
+      class="mx_FileDropTarget_image"
+      src="image-file-stub"
+    />
+    Drop file here to upload
+  </div>
+</DocumentFragment>
+`;
+
+exports[`FileDropTarget should render nothing when idle 1`] = `<DocumentFragment />`;