Add ?no_universal_links=true to OIDC url so EX doesn't try to handle it (#29439)
* Add `?no_universal_links=true` to OIDC cb url so EX doesn't try to handle it This is specific to macOS and only affects cases where auth is attempted in the non-default browser Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Strip no_universal_links after auth Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update MAS Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update playwright-common Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Bump @element-hq/element-web-playwright-common Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
committed by
GitHub
parent
7951e48291
commit
2395cb1402
@@ -477,6 +477,8 @@ export default abstract class BasePlatform {
|
||||
// The redirect URL has to exactly match that registered at the OIDC server, so
|
||||
// ensure that the fragment part of the URL is empty.
|
||||
url.hash = "";
|
||||
// Set no_universal_links=true to prevent the callback being handled by Element X installed on macOS Apple Silicon
|
||||
url.searchParams.set("no_universal_links", "true");
|
||||
return url;
|
||||
}
|
||||
|
||||
|
||||
@@ -43,6 +43,7 @@ function onTokenLoginCompleted(): void {
|
||||
// a little nasty but let's redirect to clear them.
|
||||
const url = new URL(window.location.href);
|
||||
|
||||
url.searchParams.delete("no_universal_links");
|
||||
url.searchParams.delete("loginToken");
|
||||
url.searchParams.delete("state");
|
||||
url.searchParams.delete("code");
|
||||
|
||||
Reference in New Issue
Block a user