From 204bbebfca696a331b9e4b1260c72b6135998823 Mon Sep 17 00:00:00 2001 From: Luke Barnard Date: Tue, 28 Nov 2017 15:49:11 +0000 Subject: [PATCH] Only calculate displayed groups if flair enabled --- .../views/messages/SenderProfile.js | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/components/views/messages/SenderProfile.js b/src/components/views/messages/SenderProfile.js index 1d21ffd0fd..5ca2fc6ed8 100644 --- a/src/components/views/messages/SenderProfile.js +++ b/src/components/views/messages/SenderProfile.js @@ -105,11 +105,20 @@ export default React.createClass({ return ; // emote message must include the name so don't duplicate it } - const displayedGroups = this._getDisplayedGroups( - this.state.userGroups, this.state.relatedGroups, - ); + let flair =
; + if (this.props.enableFlair) { + const displayedGroups = this._getDisplayedGroups( + this.state.userGroups, this.state.relatedGroups, + ); - name = displayedGroups.length > 0 ? name.replace(' (IRC)', '') : name; + // Backwards-compatible replacing of "(IRC)" with AS user flair + name = displayedGroups.length > 0 ? name.replace(' (IRC)', '') : name; + + flair = ; + } const nameElem = { name || '' }; @@ -118,13 +127,7 @@ export default React.createClass({ { nameElem } - { this.props.enableFlair ? - - : null - } + { flair } ; const content = this.props.text ?