Move the active tab in user settings to the dialog title (#12481)
* Convert tabbedview to functional component The 'Tab' is still a class, so now it's a functional component that has a supporting class, which is maybe a bit... jarring, but I think is actually perfectly logical. * put comment back * Fix bad tab ID behaviour * Make TabbedView a controlled component This does mean the logic of keeping what tab is active is now in each container component, but for a functional component, this is a single line. It makes TabbedView simpler and the container components always know exactly what tab is being displayed rather than having to effectively keep the state separately themselves if they wanted it. Based on https://github.com/matrix-org/matrix-react-sdk/pull/12478 * Move the active tab in user settings to the dialog title Separated by a colon, as per the new design. * Update snapshots * Update a playwright test * Fix more tests / snapshots * Attempt to test all the cases of titleForTabID * More tests
This commit is contained in:
@@ -53,7 +53,7 @@ interface IProps {
|
||||
"top"?: React.ReactNode;
|
||||
|
||||
// Title for the dialog.
|
||||
"title"?: JSX.Element | string;
|
||||
"title"?: React.ReactNode;
|
||||
// Specific aria label to use, if not provided will set aria-labelledBy to mx_Dialog_title
|
||||
"aria-label"?: string;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user